search

GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
477 stars 127 forks source link

use a signed type for waypt_counts and route counts. #1307

Closed tsteven4 closed 3 months ago

tsteven4 commented 3 months ago

Although larger in Qt6, the underlying type is signed.

This reduces the number of tidy bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions warnings by 108, without picking up any other tidy warnings.

Also see the discussion at https://google.github.io/styleguide/cppguide.html#Integer_Types

tsteven4 commented 3 months ago

-Wformat= warnings reduced by 3. -Wsign-conversion reduced by 52.