GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
473 stars 126 forks source link

use constexpr for constants, match parms in declaration and definition. #1314

Closed tsteven4 closed 1 month ago

tsteven4 commented 1 month ago

The mathematical constants finally appear in in C++20, we require only C++17. M_PI is POSIX. It is also in \<QtMath> as well as qDegreesToRadians and qRadiansToDegrees.

I leaning toward your plan "quit thinking about this and move on", this PR is already merged.

The extra digits did change the mantissa by ~2000 on my 64 bit system.