GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
473 stars 126 forks source link

update shapelib to 1.6.1 #1323

Closed tsteven4 closed 4 weeks ago

tsteven4 commented 4 weeks ago

This resolves the following build warnings on windows:

D:\a\gpsbabel\gpsbabel\shapelib\safileio.c(170): warning C4113: 'SAFile (__cdecl *)(const char *,const char *)' differs in parameter lists from 'SAFile (__cdecl *)(const char *,const char *,void *)'
D:\a\gpsbabel\gpsbabel\shapelib\safileio.c(171): warning C4113: 'int (__cdecl *)(const char *)' differs in parameter lists from 'int (__cdecl *)(const char *,void *)'
robertlipe commented 4 weeks ago

Heh. They're adding big endian. (Odd, since nothing that has any business running GPSBabel has been big endian in many years at this point...) In another window, I'm removing some of ours...and rolling my eyes at most of what's left.

On Wed, Aug 14, 2024 at 7:36 PM tsteven4 @.***> wrote:

This resolves the following build warnings on windows:

D:\a\gpsbabel\gpsbabel\shapelib\safileio.c(170): warning C4113: 'SAFile (cdecl )(const char ,const char *)' differs in parameter lists from 'SAFile (cdecl )(const char ,const char ,void )' D:\a\gpsbabel\gpsbabel\shapelib\safileio.c(171): warning C4113: 'int (cdecl )(const char )' differs in parameter lists from 'int (cdecl )(const char ,void *)'

— Reply to this email directly, view it on GitHub https://github.com/GPSBabel/gpsbabel/pull/1323#issuecomment-2290156508, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD33WNC7CV4LWJ2J6VJLZRPZYPAVCNFSM6AAAAABMRKAHYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQGE2TMNJQHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tsteven4 commented 4 weeks ago

Like us (#1315) they are changing from run time endian detection to compile time endian detection.