GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
473 stars 126 forks source link

clang-tidy-18 fixes performance-unnecessary-copy-initialization #1328

Closed tsteven4 closed 3 weeks ago

codacy-production[bot] commented 3 weeks ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.01% :white_check_mark: 91.67%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (9ba244b2bd78803c8b25b953c7ace8c3a40c36c3) | 27549 | 17262 | 62.66% | | | Head commit (d8bbab39d568fa6e8122da3823f6d8b7c8547f36) | 55081 (+27532) | 34507 (+17245) | 62.65% (**-0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#1328) | 12 | 11 | **91.67%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

robertlipe commented 3 weeks ago

LGTM Interesting that's the only getter it singles out.

tsteven4 commented 3 weeks ago

we don't have many getters that return references.