Update scatter.glsl to fix issue with textures

GPSnoopy / RayTracingInVulkan

Implementation of Peter Shirley's Ray Tracing In One Weekend book using Vulkan and NVIDIA's RTX extension.

BSD 3-Clause "New" or "Revised" License

1.28k stars 116 forks source link

Closed PMunkes closed 3 years ago

PMunkes commented 3 years ago

This proposed change fixes #36 without any visual impact.

GPSnoopy commented 3 years ago

Hi @PMunkes , thanks for looking into this.

I'll come back to it in a few weeks, family matters to attend to first. But I wanted you to know are not being ignored :-)

PMunkes commented 3 years ago

Hi @GPSnoopy, take your time, there is no urgency here.

I really enjoy experimenting with this project, so don't be surprised if there's another Pull Request when you return.

PMunkes commented 3 years ago

Updated the pull request since I found the root cause. The problem was that the texture indices were not specified to be nonuniform. https://github.com/KhronosGroup/GLSL/blob/master/extensions/ext/GL_EXT_nonuniform_qualifier.txt

PMunkes commented 3 years ago

Found a very interesting link, in case anyone finds this later and wants more information: https://gpuopen.com/learn/porting-detroit-2/