No meta programming / subscripting on imports / exports

[coolaj86]

Rationale

• Easy to read "Is this function exported" rather than "Where are all exported functions"
• Tooling (i.e. tsc) can't read exports that require runtime code to examine
• Possible security vuln: perhaps untrusted code can be placed in a trusted folder

Example: Exports

Bad

Object.assign(module.exports, {
  create,
  get,
  update,
  destroy
});

Good

let Crud = module.exports;

Crud.create = function () {
  // ...
};

// ...

Example: Dynamic Imports

Bad

let DynamicThings = {};
Fs.readdir(`./things/`).forEach(function (node) {
  DynamicThings[node] = require(`./things/${node}`);
});

Good

If possible, the requires should be listed manually

let DynamicThings = {
  Foo: require('./foo.js'),
  Bar: require('./bar.js'),
};

Otherwise, create a template for npm pre-publish (which also runs on npm install, locally) or similar:

let js = `"use strict";
let DynamicThings = {};
`;

Fs.readdir(`./things/`).forEach(function (node) {
  // the final require will have the literal value of ${node}, not the variable
  js += `DynamicThings.${node} = require(\`./things/${node}\`);\n`
});
js += `\n`;

Fs.writeFile(`./generated-things.js`, js, `utf8`);

Require the generated file:

let DynamicThings = require('/generated-things.js');