search

GPUOpen-Archive / Anvil

Anvil is a cross-platform framework for Vulkan
MIT License
594 stars 62 forks source link

Access to glslang::TProgram::getInfoDebugLog #101

Closed Silverlan closed 6 years ago

Silverlan commented 6 years ago

Anvil only provided access to getInfoLog, but not to getInfoDebugLog, which contains additional debug information.

DominikWitczakAMD commented 6 years ago

@Silverlan : According to Appveyor, this change doesn't build with VS 2017. Would you mind submitting a fix? Thanks.

Silverlan commented 6 years ago

@DominikWitczakAMD The errors are unrelated to my changes:

c:\anvil\src\wrappers\image.cpp(924): error C2220: warning treated as error - no 'object' file generated [C:\anvil\build_x86\Anvil.vcxproj]
c:\anvil\src\wrappers\image.cpp(900): error C2220: warning treated as error - no 'object' file generated [C:\anvil\build_x86\Anvil.vcxproj]
c:\anvil\src\wrappers\image.cpp(924): warning C4701: potentially uninitialized local variable 'result' used [C:\anvil\build_x86\Anvil.vcxproj]
c:\anvil\src\wrappers\image.cpp(900): warning C4701: potentially uninitialized local variable 'result' used [C:\anvil\build_x86\Anvil.vcxproj]

These were fixed by ArkadiuszSarwa after my pull request: https://github.com/GPUOpen-LibrariesAndSDKs/Anvil/commit/e7df10d81edc85a73a2c31b70de8ea83c0aa8e74

DominikWitczakAMD commented 6 years ago

Some heavy changes are coming in so I've merged these changes manually to our internal repository. The modifications you proposed will be included in the update, coming later this week. Many thanks!