search

GPUOpen-Archive / Anvil

Anvil is a cross-platform framework for Vulkan
MIT License
594 stars 62 forks source link

fix the vkCmdCopyBuffer validation layers warning and renderdoc errors #107

Closed Euxiniar closed 6 years ago

Euxiniar commented 6 years ago

a small modification that makes the validation layers happy.

Euxiniar commented 6 years ago

pNext is not recognized by renderdoc, and other software like this one. Thus, renderdoc detects errors on device features, when there are none. To modify this, it is necessary to pass the features in the pEnabledFeatures of the VkDeviceCreateInfo, instead of passing it in the pNext parameter.

DominikWitczakAMD commented 6 years ago

I agree with the missing TRANSFER_DST usage flag - good catch.

However, the part with the RenderDoc - it sounds like something you should report to the other project's owner. Unless there are strong reasons, I'm disinclined to include changes which make Anvil's source code more tedious to understand. With all the extensions it already supports, it's already becoming a bit of a monster to follow at some places.

DominikWitczakAMD commented 6 years ago

Should've mentioned - I've fixed the missing flag problem internally. This fix will go out later this week.

If you're OK with chasing Renderdoc's owner about the other issue, please close the issue. Otherwise, the room is open for discussion of course :-)

Euxiniar commented 6 years ago

All right, as it was relatively easy to fix, I didn't ask myself the question 😃 I'll report it to Renderdoc if you prefer !