search

GPUOpen-Archive / Anvil

Anvil is a cross-platform framework for Vulkan
MIT License
594 stars 62 forks source link

Suggestion: Add CMake option to use SDK location for glslang library #118

Closed Silverlan closed 5 years ago

Silverlan commented 5 years ago

A CMake option was added (#49) to allow using the vulkan headers from the installed SDK instead of the ones shipped with Anvil, which is great, but Anvil still always uses the shipped version of glslang instead of the SDK version. Since the glslang library is part of the vulkan SDK anyway, I think the CMake option should probably also make it so the SDK version is used instead of the shipped version, or there should be an additional CMake option for that.

// Edit: In fact, it's a bit of a source of confusion right now. I originally assumed that _ANVIL_USE_BUILT_IN_VULKANHEADERS referred to ALL headers from the SDK (including glslang and spirv-tools), so I linked against the SDK versions of those libraries. Since the SDK version differed from the Anvil version, that didn't go so well.

DominikWitczakAMD commented 5 years ago

Addressed internally. Anvil's CMake file now includes a new ANVIL_USE_BUILT_IN_GLSLANG option which is enabled by default. If it is disable, a new ANVIL_GLSLANG_PATH option will allow apps to specify an alternative location to use as glslang's root directory.

DominikWitczakAMD commented 5 years ago

Fixed in the latest version.