GPUOpen-Drivers / AMDVLK

AMD Open Source Driver For Vulkan
MIT License
1.68k stars 158 forks source link

Performance hit when maintenance4 feature is used #326

Open Blisto91 opened 1 year ago

Blisto91 commented 1 year ago

A while back the maintenance4 feature was disabled in dxvk due to both amdvlk and the Windows AMD driver taking a big performance hit when it is used. See https://github.com/doitsujin/dxvk/issues/2784#issuecomment-1209980906 for original dxvk dev comment and https://github.com/doitsujin/dxvk/issues/2784#issuecomment-1209501841 for original issue comparison between dxvk with and without the feature. Also see commit https://github.com/doitsujin/dxvk/commit/ec0c377cf8cf5ca9496dc3786077d3aba79b06d5

During some quick spot testing with my own new setup (7900XTX) i have not found it to be as big a hit as shown above (~30%), but i see around a ~5% drop whereas radv doesn't seem to really change. Dunno if perf percentage hit depends on exact setup used. I'm personally only using 1080p at the moment so i'm not GPU bound in the same way.

Below are some examples with dxvk commit before feature was disabled (first screenshot) and when it was (second)

METAL GEAR SOLID V: THE PHANTOM PAIN [Framerate has been unlocked through config](https://www.pcgamingwiki.com/wiki/Metal_Gear_Solid_V:_The_Phantom_Pain#High_frame_rate) ![Screenshot_20230617_185331](https://github.com/GPUOpen-Drivers/AMDVLK/assets/47954800/b4cbb9a3-7814-4b47-9d6f-772aad39e686) ![Screenshot_20230617_185524](https://github.com/GPUOpen-Drivers/AMDVLK/assets/47954800/63acecb0-c5e8-49f5-8b92-1b828714fb52)
The Witcher 3 d3d11 ![Screenshot_20230617_191151](https://github.com/GPUOpen-Drivers/AMDVLK/assets/47954800/f3a0aef9-28f4-4e4d-9373-3e2c1c99f3a8) ![Screenshot_20230617_190921](https://github.com/GPUOpen-Drivers/AMDVLK/assets/47954800/6be440b4-d611-49f1-88fc-dbbf0e81569f)
The Witcher 3 d3d11 radv for comparison ![Screenshot_20230617_191904](https://github.com/GPUOpen-Drivers/AMDVLK/assets/47954800/7ba81e5a-11b6-4d7a-be72-3929a35d0416) ![Screenshot_20230617_192040](https://github.com/GPUOpen-Drivers/AMDVLK/assets/47954800/dedee437-3141-408d-a1dd-cefd1c7f8f75)
Blisto91 commented 2 months ago

As a quick update maintenance4 have been enabled on master dxvk again, just not for AMDs drivers https://github.com/doitsujin/dxvk/commit/6ef98c613fa2f78861d2bb06f8e2af17ae2db0ef