Closed baryluk closed 3 months ago
Using a workaround for gcc 13.2, for that old tagged release which I described in the dxc issue https://github.com/microsoft/DirectXShaderCompiler/issues/5949
patching one file for missing include (#include <cstdint>
in DirectXShaderCompiler/tools/clang/include/clang/Basic/Version.h
, and adding extra cmake flags (-DCMAKE_CXX_FLAGS="-Wno-error=stringop-overflow -Wno-changes-meaning"
) for the compiler to ignore some warnings / errors, I compiled this older dxc.
Then amdvlk does build:
[1/148] Generating pipelines/g_internal_shaders.h, pipelines/g_GpuRtLibrary.h
Launching threads for raytracing shader compilation...
Raytracing shader compilation completed with no errors.
Launching threads for raytracing shader compilation...
Raytracing shader compilation completed with no errors.
...
So, this looks like an issue of amdvlk xgl with newer dxc.
I've run into a similar issue trying to compile the latest AMDVLK release. Code compiles with an older version of DirectXShaderCompiler but the latest version fails with error: firstbithigh is not yet implemented for 64-bit width components when targetting SPIR-V
.
Versions used: amdvlk v-2024.Q1.3 glslang 14.1.0 xgl b7100c18eb2d134098738f97d7cc3a26e485862f pal 42e29f4d3d528c6a59c2db77fb6d70127fb9ffab llpc 14535c028dc70a093d95a95efedb749812c1e77d llvm-project da55e9e39bc7868016b7b265aa535dff84b7d591 MetroHash 18893fb28601bb9af1154cd1a671a121fff6d8d3 CWPack 4f8cf0584442a91d829d269158567d7ed926f026 gpurt 2e6d528610f45a99723d6e4f15f24da12fd6a1e5
Working DirectXShaderCompiler version: DirectXShaderCompiler v1.7.2308
Not working DirectXShaderCompiler version: DirectXShaderCompiler v1.8.2403.2
Also ran into this build issue with VulkanSDK1.3.275+'s DXC tools. We are working on it.
could you help to try PR-8 please? https://github.com/GPUOpen-Drivers/gpurt/pull/8
I added your patch to my RPM build and was able to get a successful build with DirectXShaderCompiler v1.8.2403.2.
https://build.opensuse.org/package/show/home:mareksapota:branches:X11:XOrg/amdvlk
Fix merged.
gcc version 13.2.0 (Debian 13.2.0-6)
DirectXShaderCompiler from Today's main branch at 64030a4e01e27c608b6c5f1ab5add43575e086f9
I know, README.md says to use tagged earlier release, but it has issues with gcc 13.2.
Building (I was doing with
ninja --keep-going 0
, rest looks to compile, and this is the only failure I could find):