search

GPUOpen-Drivers / llpc

LLVM-Based Pipeline Compiler
MIT License
166 stars 115 forks source link

[Test] Fix and use lit flags for lgc #2833

Closed Flakebi closed 10 months ago

Flakebi commented 10 months ago

The flags exposed to lit are not interface flags (because lgc is not an interface library), this was a copy-paste error.

amdvlk-admin commented 10 months ago

Test summary for commit 1eb5d4217f8cbf99f3e3c0a3fd40b728b170a9bd

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)
Flakebi commented 10 months ago

but how does it interact with the in-flight change to have a version library?

Not that good, seems like get_target_property(LIT_DEFINITIONS LLVMlgc COMPILE_DEFINITIONS) only returns definitions that are immediately on the target but not on dependencies. I guess we can change it to get_target_property(LIT_DEFINITIONS llpc_version INTERFACE_COMPILE_DEFINITIONS) when the version library exists? (Note the INTERFACE_COMPILE_DEFINITIONS)

Flakebi commented 10 months ago

Closing as this depends on the llpc_version library, which was only merged internally. (This change will see the light in this repo on the next promotion.)