search

GPUOpen-Drivers / llpc

LLVM-Based Pipeline Compiler
MIT License
166 stars 115 forks source link

Add support for SHT_RELA in vkgc #2857

Closed jayfoad closed 10 months ago

jayfoad commented 10 months ago

Currently LLVM generates relocations in an ELF SHT_REL section. To allow for changing the compiler to use SHT_RELA instead, this patch updates vkgcElfReader and vkgcPipelineDumper to support both section types.

jayfoad commented 10 months ago

TBH I am not too happy with this. vkgcElfReader is all based around known section names instead of section types, and now it is assuming that only one of ".rel.text" and ".rela.text" will exist.

amdvlk-admin commented 10 months ago

Test summary for commit 631d2e2b1b0d8fa2bb4c35986dfb34110f3a5113

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)