search

GPUOpen-Drivers / llpc

LLVM-Based Pipeline Compiler
MIT License
166 stars 115 forks source link

Refine the commit f9da39114d #2858

Closed AMD-dwang closed 10 months ago

AMD-dwang commented 10 months ago

A better way to use Map.

amdvlk-admin commented 10 months ago

Test summary for commit 4f0e99224e87e533385eef78f9cd55e2e0d6fca1

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35163/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34000/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)
AMD-dwang commented 10 months ago

Well, why can't I merge? Does it require approval from everyone who comments in this PR?

jasilvanus commented 10 months ago

@jayfoad is not an approver. @Flakebi is though, so he could approve.

tsymalla-AMD commented 10 months ago

Thanks, but I'd rather edit the commit message (title + message) at least, since it is not really informative without looking up the explicit commit.

Flakebi commented 10 months ago

You can edit the commit title and message when you ‘squash and merge’.