search

GPUOpen-Drivers / llpc

LLVM-Based Pipeline Compiler
MIT License
166 stars 115 forks source link

Remove the method isTessOffChip #2860

Closed amdrexu closed 10 months ago

amdrexu commented 10 months ago

On GFX9+, tessellation is always in off-chip mode. Since we just support GFX10+, the method isTessOffChip always returns TRUE for us.

amdvlk-admin commented 10 months ago

Test summary for commit a84beb9c6ce641ecb1fba3d01ccc1d49a44e3d19

CTS tests (Failed: 4349/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 33037/69228 (47.7%)
    • Failed: 2174/69228 (3.1%)

      Failures: ``` FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_combined_image_sampler Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_storage_texel_buffer Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers2_samplers1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers3_samplers3 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource15 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource7 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource15 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers1_sets1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers3_sets1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets2_push_set1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets3_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tese_sets4_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets2_push_set1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets3_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets1_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets4_push_set3 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tesc_uniform_buffer Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_combined_image_sampler Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_storage_image Stack trace: Crash ... ```

    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 33067/69215 (47.8%)
    • Failed: 2175/69215 (3.1%)

      Failures: ``` FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_combined_image_sampler Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_storage_texel_buffer Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers2_samplers1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers3_samplers3 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource15 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource7 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource15 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers1_sets1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers3_sets1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets2_push_set1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets3_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tese_sets4_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets2_push_set1 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets3_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets1_push_set0 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets4_push_set3 Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tesc_uniform_buffer Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_combined_image_sampler Stack trace: Crash FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_storage_image Stack trace: Crash ... ```

    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)
amdvlk-admin commented 10 months ago

Test summary for commit 66d6c103773c1bf06e6613e6b728a66d6865996c

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)