search

GPUOpen-Drivers / llpc

LLVM-Based Pipeline Compiler
MIT License
163 stars 116 forks source link

Simplify calls to Builder::ReadBuiltInInput. #2883

Closed tsymalla closed 6 months ago

tsymalla commented 6 months ago

In many places, we are calling Builder::CreateReadBuiltInInput with default arguments, cluttering the call signature. This change simplifies that a bit by adding default arguments to the declaration.

amdvlk-admin commented 6 months ago

Can one of the admins verify this patch?

Flakebi commented 6 months ago

ok to test

tsymalla-AMD commented 6 months ago

retest this please

amdvlk-admin commented 6 months ago

Test summary for commit 96fda751ad8e3ccc4463944e112de68baa2fba76

CTS tests (Failed: 1/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 1/69215 (0.0%)

      Failures: ``` FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_sect_combined_image_sampler_custom_border_color Stack trace: Flake ```

    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)
tsymalla commented 6 months ago

Retest this please

amdvlk-admin commented 6 months ago

Test summary for commit 96fda751ad8e3ccc4463944e112de68baa2fba76

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)