search

GPUOpen-Drivers / llpc

LLVM-Based Pipeline Compiler
MIT License
166 stars 115 forks source link

Remove the unused user data EsGsLdsSize #2885

Closed amdrexu closed 9 months ago

amdrexu commented 9 months ago

This user data was added to keep some compatibility with old PAL. At that time, PAL expected this user data to handle ES-GS merged shader and NGG correctly on GFX9 and GFX10.1. But LLPC doesn't need this user data at all since we always know ES stage when building the pipeline. And the LDS calculation and allocation of GS stage are applied to full ES-GS pipeline.

In this change, the user data EsGsLdsSize is not added to entry-point argument. This SGPR is saved. Also, we don't need to tell PAL with metadata EsGsLdsSize.

amdvlk-admin commented 9 months ago

Test summary for commit 28014e9f5f0e5e8c7bce442c313f5c026a8e4b7e

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33974/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)