Closed afd closed 3 years ago
how to build xgl with asan enabled? I tried on ubuntu 18.04, I failed to generating makefile through " cmake $xgl_path -DCMAKE_BUILD_TYPE=RelWithDebInfo -DXGL_USE_SANITIZER=Address". I got error message " Host compiler appears to require libatomic, but cannot find it." but I have already installed libatomic-ops-dev libatomic1:amd64. Do you have any idea? @afd @kuhar
@ruiling see https://github.com/GPUOpen-Drivers/llpc/blob/dev/docker/amdvlk.Dockerfile#L84 for complete instructions
Alternatively, you can also just grab the latest sanitizer docker image produced by the nightly cron job with something like:
sudo docker pull gcr.io/stadia-open-source/amdvlk_release_clang_sanitizers_on:nightly
Issue fixed in llvm https://reviews.llvm.org/D89092. It will be available after next llvm promotion. sorry for the late reply.
This has recently started passing: https://github.com/GPUOpen-Drivers/llpc/runs/1295716691?check_suite_focus=true
Thanks for the fix, @ruiling. In the future, could you please add a comment with a related phabricator revision before it's actually committed, so that we get a change participate in code review or downstream testing too?
sounds good idea, thanks for the advice @kuhar
Found using a build with assertions ON and sanitizers ON, using these commit hashes:
/vulkandriver/drivers/AMDVLK 88d3e8e911055fe9c6a7ae1960b9fae13a70a9cf /vulkandriver/drivers/llpc aacd74a46f62e652b63cfb2b6f145f6e489d74d4 /vulkandriver/drivers/llvm-project ccbc834ac4f92e63a9a003bd5a18cb9fcf3c6121 /vulkandriver/drivers/pal 9074bd0bdaf67fa84399dfabed3ec437951838f8 /vulkandriver/drivers/spvgen c054813a9a894e32aaaa04c6717a667c15f60cfd /vulkandriver/drivers/third_party/cwpack 7387247eb9889ddcabbc1053b9c2052e253b088e /vulkandriver/drivers/third_party/metrohash 712f76fee75d69b23a1ea8f6465752c3ccaaf9a2 /vulkandriver/drivers/xgl 598c6832a4983f5b75b38a589fca5be80a2f3bb0
Sanitizers are required to trigger this issue. Assertions should not be required.
Files needed to reproduce the issue
Command to reproduce the issue:
I see this output:
Issue found by the GraphicsFuzz project.