search

GPUOpen-Effects / FidelityFX-FSR-Unity-URP

FidelityFX FSR 1.0 for the Unity URP
MIT License
104 stars 21 forks source link

Ported the URP 10.6.0 patch over to URP 12.1.4 #6

Open OBXS opened 2 years ago

OBXS commented 2 years ago

Tested working on Unity 2021.2.13, but should work on Unity 2021.2.9 ~ 13

Edit: I just noticed that the Sample Bias variant on SurfaceInput.hlsl will never be called because ① the Lit.shader that uses SurfaceInput.hlsl doesn't set "_AMD_FSR" as keyword (#pragma multi_compile), and it's never set to be enabled in C#. ② "amd_fsr_mipmap_bias" is never defined as a variable in the shader.

Both of these also appears to be the case for the 10.6.0 patch, was this intentional?

abhiavana commented 2 years ago

@OBXS When applying this patch - I get the following error: error: corrupt patch at line 142

Unity 2021.2.9f1

OBXS commented 2 years ago

Huh, that's interesting, I've made sure it worked when I commited it :/ I'll look into it when I have the time. (FSR 2.0's just around the horizon though so no promises)

ROBYER1 commented 2 years ago

@OBXS When applying this patch - I get the following error: error: corrupt patch at line 142

Unity 2021.2.9f1

Same issue here, did you ever get it working?

alexArayaYahoo commented 2 years ago

Hi. i did follow the following steps without luck:

  1. I download the zip file, and extracted from it the FSR1.0-For-URP10.6.0-Patch.patch file.
  2. copy the patch file in the C:\urp_test_git\fsr_test\Library\PackageCache directory (i'm not sure if this step is correct)
  3. open on C:\urp_test_git\fsr_test\Library\PackageCache directory a git bash console, and did run the command: git apply FSR1.0-For-URP10.6.0-Patch.patch
  4. the git console dont show me any message, and when i open the project on unity editor i can't find the option to activate fsr on the camera settings ¿ any idea ?

Thanks.

rocco-haro commented 1 year ago

@OBXS would you recommend ditching this version and exploring how to incorporate v2 into our URP project?