GPUOpen-Effects / FidelityFX-FSR2

FidelityFX Super Resolution 2
Other
1.97k stars 181 forks source link

Unreal Engine 5.0.2 compiles PS4/PS5 version with errors. #12

Open YuQing-Ding opened 2 years ago

YuQing-Ding commented 2 years ago

Hello,

We found fatal error about FSR 2.0 UE5.0.2 version on PlayStation 4 and PlayStation 5, this can affect the compilation and cause it to fail.

Here is Logs: PS4_Build_Log.txt PS5_Build_Log.txt

Any suggestions? Any advice would be appreciated!

YuQing-Ding commented 2 years ago

Update: We tried to compile the PC version, and everything works fine! But PS4 and PS5 still can't compile.

BartmanAbyss commented 2 years ago
#define min16float                  half
#define min16float2                 half2
#define min16float3                 half3
#define min16float4                 half4

#define min16int                    short
#define min16int2                   short2
#define min16int3                   short3
#define min16int4                   short4

#define min16uint                   ushort
#define min16uint2                  ushort2
#define min16uint3                  ushort3
#define min16uint4                  ushort4
YuQing-Ding commented 2 years ago

@BartmanAbyss Did you solved this problem?

BartmanAbyss commented 2 years ago

We don't use Unreal Engine, but it works with these defines.

YuQing-Ding commented 2 years ago

@BartmanAbyss Got it, so which files are you modified? I don't have much of a clue right now. :(

curs0 commented 2 years ago

Those are defined here FSR2\Source\ffx-fsr2-api\shaders\ffx_common_types.h but changing them doesn't seem to fix the errors, we also noted that the current plugin definition supports only Windows platform, so it is disabled by default when compiling for PS4/5 platforms (need to change it in .uplugin definition). Has anyone managed to make it work with the Playstation?

YuQing-Ding commented 2 years ago

Those are defined here FSR2\Source\ffx-fsr2-api\shaders\ffx_common_types.h but changing them doesn't seem to fix the errors, we also noted that the current plugin definition supports only Windows platform, so it is disabled by default when compiling for PS4/5 platforms (need to change it in .uplugin definition). Has anyone managed to make it work with the Playstation?

@curs0 I consulted with SIE's technical department, but they don't seem interested in this. I will continue to follow up and investigate the case and if there are any new developments I will post them here

YuQing-Ding commented 2 years ago

I hope AMD can give us a reasonable answer, because this thing is a panacea for optimization, which can greatly save the time and cost of optimization.

@AMD

dyanikoglu commented 2 years ago

Hello. I was digging to reach same goal for our project, and realized the public plugin doesn't have console support at all (which is expected because of NDA). If you check the Source folder, you'll only see renderer implementation for DX12 and Vulkan. Since Playstation 5 uses its own renderer, I feel like even if you get the plugin compiled somehow, it won't work when deployed.

Download page mentions Xbox platform, but nothing about Playstation unfortunately. https://gpuopen.com/fidelityfx-superresolution-2/#download

It'd be nice to get some information from AMD side about Playstation 5 source for FSR 2.0.

@YuQing-Ding

dyanikoglu commented 2 years ago

Also tagging @rys for heads-up, since he's only person visible in repository history.