GPUOpen-Effects / FidelityFX-FSR2

FidelityFX Super Resolution 2
Other
1.98k stars 181 forks source link

patchResourceBindings can silently fail. #92

Open sagaceilo opened 1 year ago

sagaceilo commented 1 year ago

This code: https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/e812d9e4c439106e88a6f7d40ca6fef3e88fef6d/src/ffx-fsr2-api/ffx_fsr2.cpp#L420

Should be wrapped with FFX_VALIDATE. In case some binding are not found FFX_ERROR_INVALID_ARGUMENT will be returned, but lib will leave this semi-filled pipeline and continue and return FFX_OK on exit. It should pass error code immediately imho.