typo in computing shadow accumulation

GPUOpen-Effects / TressFX

DirectX 12 and Vulkan libraries that provide convenient access to realistically rendered and simulated hair and fur

MIT License

795 stars 131 forks source link

typo in computing shadow accumulation #49

Open adiblev opened 1 year ago

adiblev commented 1 year ago

Hi guys,

Going over the code we assume that intention was to compute: #fibers = distance / (strand radius + spacing between strands) but due to a typo used multiplication instead of addition.

Was that indeed a typo or intentional?

https://github.com/GPUOpen-Effects/TressFX/blob/ba0bdacdfb964e38522fda812bf23169bc5fa603/src/Shaders/TressFXLighting.hlsl#L196