`g_ScreenProbes_OverrideTileBuffer` unused during adaptive sampling

GPUOpen-LibrariesAndSDKs / Capsaicin

AMD ARR team rendering framework

MIT License

363 stars 33 forks source link

`g_ScreenProbes_OverrideTileBuffer` unused during adaptive sampling #20

Open Solicey opened 2 months ago

Solicey commented 2 months ago

https://github.com/GPUOpen-LibrariesAndSDKs/Capsaicin/blob/d642e5dbb35c443fe681936be7806dce1042b6cc/src/core/src/render_techniques/gi10/gi10.comp#L626 should be changed to:

InterlockedExchange(g_ScreenProbes_ProbeSpawnBuffer[g_ScreenProbes_OverrideTileBuffer[index]], ScreenProbes_PackSeed(seed), index);

so as to match with the GI-1.0 technical report.

gboisse commented 2 months ago

Thanks for reporting this, and you're correct, good spotting. We fixed this internally already and will include the fix in a subsequent update of Capsaicin.