search

GPUOpen-LibrariesAndSDKs / Capsaicin

AMD ARR team rendering framework
MIT License
363 stars 32 forks source link

Shadow / bias issue? #5

Closed Firesampo closed 5 months ago

Firesampo commented 1 year ago

Hi,

I'm getting a weird issue that looks almost like some kind of shadow map self-bias error on some materials. The scene I'm testing with is originally converted from UE, and it has been working fine with my other test projects.

Since it renders mostly OK, I assume there's something wrong in rendering certain material types? (I'm guessing reflections?)

Uploaded a video clip here:

https://drive.google.com/file/d/1CoWiPlcMJjRl91HPn2X--ldzToypptUN/view

gboisse commented 1 year ago

Hi there, that's quite a strange artefact, I don't think we've ever seen this on our side.

Would it be possible for you to send us the scene so we investigate? Or a smaller version reproducing the issue if you prefer not sharing the whole content?

Firesampo commented 1 year ago

Hey,

I uploaded the GLTF scene I'm using here:

https://drive.google.com/file/d/1QXikNe0CTFVo4UsoCOkzAWDcBp0uPn14/view?usp=sharing

br, Sami

gboisse commented 1 year ago

Hi Sami,

Very cool scene, thanks!

I could repro. the issue I think (not 100% sure as it looks different on my AMD card than on your NVIDIA GPU) but I am fairly confident it should be the same issue:

piano_scene-00

It seems something going weird with the normal mapping... When turning it off, this is what I get:

piano_scene-01

There isn't really a switch available in Capsaicin to toggle normal mapping on/off but you can simply comment out that one line:https://github.com/GPUOpen-LibrariesAndSDKs/Capsaicin/blob/7e3beea447e396ca97cc6a49e766c04b25d602e3/src/core/src/render_techniques/visibility_buffer/visibility_buffer.frag#L101

Let me know if this fixes it for you.

We've implemented a bunch of fixes to our normal mapping code in our internal version of Capsaicin, which will be part of the next release so hopefully it'll sort this issue out too.

maoliver-amd commented 5 months ago

The latest verion 1.1 is now available with a variety of new features and bug fixes, including a much more robust normal mapping code. Hopefully this issue should ne be resolved. If you still have the issue then feel free to reopen or post a new issue.