search

GPUOpen-LibrariesAndSDKs / FidelityFX-SDK

The main repository for the FidelityFX SDK.
Other
835 stars 80 forks source link

Optical flow scheduleDispatch unused parameter. #40

Open VeganPower opened 8 months ago

VeganPower commented 8 months ago

Hello, pipelineName in scheduleDispatch is not used.

https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/src/components/opticalflow/ffx_opticalflow.cpp#L465

The worst part is that it's a std::string so it allocates memory at runtime even when passing a static name. I haven't checked if the whole string construction is optimized out in release.

Same problem is not present in other component like FrameInterpolator or Fsr3 upscaler.

jlacroixAMD commented 8 months ago

I've cleaned this up locally. Will be pushed out with the next version of the SDK. Thanks.