Open QDanteQ opened 8 months ago
Hello, in previous version of FSR (before 2.2.2), we provided const pointer of wchar_t. May I ask you why did you remove const specifier, as in the backend you still do a copy of string, so you don't need to have non-const pointer?
Here's a code snippet from FidelityFX-SDK https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/d7531ae47d8b36a5d4025663e731a47a38be882f/sdk/include/FidelityFX/host/backends/dx12/ffx_dx12.h#L102
Here's from FSR2 https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/1680d1edd5c034f88ebbbb793d8b88f8842cf804/src/ffx-fsr2-api/dx12/ffx_fsr2_dx12.h#L96
Thank you for your work!
I've fixed this locally. It'll be rolled out with the next release of the FidelityFX SDK. Thank you for the feedback.
Hello, in previous version of FSR (before 2.2.2), we provided const pointer of wchar_t. May I ask you why did you remove const specifier, as in the backend you still do a copy of string, so you don't need to have non-const pointer?
Here's a code snippet from FidelityFX-SDK https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/d7531ae47d8b36a5d4025663e731a47a38be882f/sdk/include/FidelityFX/host/backends/dx12/ffx_dx12.h#L102
Here's from FSR2 https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/1680d1edd5c034f88ebbbb793d8b88f8842cf804/src/ffx-fsr2-api/dx12/ffx_fsr2_dx12.h#L96
Thank you for your work!