search

GPUOpen-LibrariesAndSDKs / FidelityFX-SDK

The main repository for the FidelityFX SDK.
Other
834 stars 78 forks source link

FSR3 sample crashes when setting Letterbox Size to 0.0 #76

Open Calinou opened 1 month ago

Calinou commented 1 month ago

The FSR3 demo from this SDK crashes if setting Letterbox Size to 0.0 in the control panel by dragging it all the way to the left, likely due to a division by zero. I suggest clamping its lower bound to something like 0.1 to avoid this.

PS: This setting performs letterboxing on both axes, not just the Y axis (so the aspect ratio remains the same). Is that intended?

jlacroixAMD commented 1 month ago

Thanks for bringing this to our attention. I've just fixed it in our internal mainline. Will be fixed here next time we update.

With regards to your question, yes it was intentional. We just wanted a quick test to show cropping could be applied and just chose to do it that way. The x and y ratios can be set individually.