GPUOpen-LibrariesAndSDKs / RadeonProRenderBlenderAddon

This hardware-agnostic rendering plug-in for Blender uses accurate ray-tracing technology to produce images and animations of your scenes, and provides real-time interactive rendering and continuous adjustment of effects.
https://gpuopen.com/radeon-prorender-suite/
Apache License 2.0
485 stars 57 forks source link

Core 2.2.15 #535

Closed VascoPi closed 2 years ago

VascoPi commented 2 years ago

PURPOSE

Update RadeonProRenderSDK to core_2.2.15.

EFFECT OF CHANGE

Updated RadeonProRenderSDK to core_2.2.15. Added Pixel Filter panel. Render Properties -> Quality -> Pixel Filter.

TECHNICAL STEPS

Enabled Pixel Filter panel for "Final" render quality. Fixed build process, excluded 'rprContextCreateMeshInstanceWithUniqueAttributes'. Fixed SDK API changes:

ARozghon commented 2 years ago

image in Blender Cycles, Pixel filters are located in the "Film" menu, so, for blender it will be better to add the same menu for the RPR plugin too

ARozghon commented 2 years ago

pixel filters are now supported and added to the Quality menu, why do we need to remove them? In the Film menu, we have an option only for transparent BG, as discussed earlier

bsavery commented 2 years ago

The TYPE of pixel filter is no longer supported in Northstar right? https://github.com/GPUOpen-LibrariesAndSDKs/RadeonProRenderSDK/blob/484351d95d5d20559331171c58bbb98fea516a66/release_notes.txt#L27

I'm not saying we remove the filter setting, just the type

VascoPi commented 2 years ago

I see it's written about TYPE of pixel filter RADIUS, so RPR_CONTEXT_IMAGE_FILTER_RADIUS is a general parameter for all pixel filters, and we don't need to generate it depending on a particular filter type anymore.