GPUOpen-LibrariesAndSDKs / RadeonProRenderBlenderAddon

This hardware-agnostic rendering plug-in for Blender uses accurate ray-tracing technology to produce images and animations of your scenes, and provides real-time interactive rendering and continuous adjustment of effects.
https://gpuopen.com/radeon-prorender-suite/
Apache License 2.0
488 stars 57 forks source link

RPRBLND-2207: Hybrid pro core 2.2.16 issues #554

Closed VascoPi closed 2 years ago

VascoPi commented 2 years ago

PURPOSE

RPRBLND-2207: Hybrid pro core 2.2.16 issues.

EFFECT OF CHANGE

Fixed KeyError: 'factor' while material updates for any of these Interactive, High, Medium, or Low Viewport renderers. Fixed ZeroDivisionError: float modulo, Modulo operation for Vector Math and RPR Math nodes. Added support for Vector Math node Project operation for Interactive renderer. Added support for Geometry node Position and Normal outputs for Interactive renderer

TECHNICAL STEPS

Adding support of HybridPro for RuleNodeParser Implementing export_hybridpro(). Added support for Position and Normal output for ShaderNodeNewGeometry node for HybridPro. Added support for ShaderNodeVectorMath PROJECT operation for HybridPro. Fixed error, __mod__ method in NodeItem. Div by zero. Fixed error, override sync_auto_adapt_subdivision method for context_hybridpro.RPRContex. Adaptive Subdivision isn't supported by HybridPro. Fixed error, override sync_auto_adapt_subdivision method for context_hybrid.RPRContex. Adaptive Subdivision isn't supported by Hybrid.

VascoPi commented 2 years ago

Discussed offline. Fixed KeyError: 'factor' for Hybrid as well.

ARozghon commented 2 years ago

when we are checking this PR has found another issue. will add ticket about it