search

GPUOpen-LibrariesAndSDKs / RadeonProRenderBlenderAddon

This hardware-agnostic rendering plug-in for Blender uses accurate ray-tracing technology to produce images and animations of your scenes, and provides real-time interactive rendering and continuous adjustment of effects.
https://gpuopen.com/radeon-prorender-suite/
Apache License 2.0
488 stars 57 forks source link

RPRBLND-2221: RAM leak with multiple material set with Displacement only #557

Closed VascoPi closed 1 year ago

VascoPi commented 2 years ago

PURPOSE

RAM leak with multiple material set with Displacement only.

EFFECT OF CHANGE

Fixed various Blender hangs.

TECHNICAL STEPS

Moved the parameter assignment to export_subdivision now it works with the final render. UI params have higher priority and are used if enabled. Change order sync_visibility and assign_materials as in sync method. Set level = 5 for displacement.

NOTES FOR REVIEWERS

Implicit subdivision assignment didn't work for displacement at all It was always overridden to None after the assignment, the only case it starts working is when material update while viewport render. This PR turns on subdivision when displacement is used. Would be great to test various displacement scenes previously subdivision wasn't applied to the mesh and now results may vary.

ARozghon commented 2 years ago

not approved by QA. now with this fix, we have improved the result with one scene and created 5 new issues with other scenes.