search

GPUOpen-LibrariesAndSDKs / RadeonProRenderBlenderAddon

This hardware-agnostic rendering plug-in for Blender uses accurate ray-tracing technology to produce images and animations of your scenes, and provides real-time interactive rendering and continuous adjustment of effects.
https://gpuopen.com/radeon-prorender-suite/
Apache License 2.0
480 stars 56 forks source link

Render settings presets and simplification #584

Closed bsavery closed 1 year ago

bsavery commented 1 year ago

PURPOSE

The goal here is to simplify settings and give easy presets for users. There will now be:

  1. Separate Quality settings
  2. Separate Final and viewport render mode (default Full mode for final, Interactive mode for viewport (viewport on mac needs to use Full I suppose)
  3. Quality presets which will set sampling levels, upscaling, etc.

@VascoPi There are some TODOS here:

  1. Implement final and viewport render modes on back end.
  2. Implement the Quality preset setting functions
  3. Remove upscaling and denoising if not using Interactive mode
  4. Make the "Denoise" button use the built in Blender Denoiser (OpenImageDenoise)

image

EFFECT OF CHANGE

Add quality section of settings which easily allows switching mode and quality presets

TECHNICAL STEPS

Changes made to code.

NOTES FOR REVIEWERS

Notes, if needed.

bsavery commented 1 year ago

@VascoPi the presets should set the:

  1. sampling levels
  2. ray depth
  3. denoise / upscale quality
ARozghon commented 1 year ago

today discussed about render settings

VascoPi commented 1 year ago

Changes looks good. Bug in device changes, discussed online.

fixed https://github.com/GPUOpen-LibrariesAndSDKs/RadeonProRenderBlenderAddon/pull/584/commits/f1101a30a46c7be1c075333c03567e29cb3325f0

VascoPi commented 1 year ago

discussed offline

fixed https://github.com/GPUOpen-LibrariesAndSDKs/RadeonProRenderBlenderAddon/pull/584/commits/f1101a30a46c7be1c075333c03567e29cb3325f0