GPUOpen-LibrariesAndSDKs / RadeonProRenderBlenderAddon

This hardware-agnostic rendering plug-in for Blender uses accurate ray-tracing technology to produce images and animations of your scenes, and provides real-time interactive rendering and continuous adjustment of effects.
https://gpuopen.com/radeon-prorender-suite/
Apache License 2.0
480 stars 56 forks source link

RPRBLND-2265: viewport render got an error if borders is out of bounds #594

Closed VascoPi closed 1 year ago

VascoPi commented 1 year ago

PURPOSE

Viewport render got an error if borders are out of bounds. In some cases render resolution width or height is zero.

EFFECT OF CHANGE

Fixed error if the render border is located out of the screen.

TECHNICAL STEPS

Now if the width or height is zero we don't render and draw the image.

ARozghon commented 1 year ago

all working fine, except for one case: if active upscale in Hybrid Pro that's provides weird GPU activity with the throttling and system short freezes image

VascoPi commented 1 year ago

In case if render border is outside the screen the render resolution is like width = 33 and height = 0. It causes "division by zero" in other parts of code the decision. Changes that are made affect the minimum size of the render result >=1. Memory leak related to another issue. https://amdrender.atlassian.net/browse/RPRBLND-2267