search

GPUOpen-LibrariesAndSDKs / RadeonProRenderBlenderAddon

This hardware-agnostic rendering plug-in for Blender uses accurate ray-tracing technology to produce images and animations of your scenes, and provides real-time interactive rendering and continuous adjustment of effects.
https://gpuopen.com/radeon-prorender-suite/
Apache License 2.0
480 stars 56 forks source link

RPRBLND-2270: Improve OCIO support, Blender 3.5 upgraded OCIO to version 2.2.0 at the moment RadeonProRenderSDK provide OCIO 2.1.1 #600

Closed VascoPi closed 1 year ago

VascoPi commented 1 year ago

PURPOSE

Switch to Blender OCIO configs.

EFFECT OF CHANGE

Removed OCIO config files, use Blender configs instead.

TECHNICAL STEPS

Removed ocio folder and adjusted create_zip_addon.py. Remove redundant code.

bsavery commented 1 year ago

What problem is this fixing? Does the OCIO files in Blender no longer work with RPR in 3.5? I'm confused.

VascoPi commented 1 year ago

What problem is this fixing? Does the OCIO files in Blender no longer work with RPR in 3.5? I'm confused.

This pull request updates OCIO configs from 1.0 to 2.1.1. just to keep up to date with RPRSDK. At the moment errors are not observed even if RPR SDK 2.1.1 uses Blender's OCIO configs 2.2.0.

bsavery commented 1 year ago

So why do we need our own configs if we can just use Blender's?

VascoPi commented 1 year ago

Concerns were only about backward compatibility versions 2.1.1 and 2.2.0, with no explicit warnings/errors. Should I remove them and try the tests?