GPUOpen-LibrariesAndSDKs / RadeonRays_SDK

Radeon Rays is ray intersection acceleration library for hardware and software multiplatforms using CPU and GPU
MIT License
1.07k stars 192 forks source link

It is open source? #206

Closed ignaloidas closed 3 years ago

ignaloidas commented 4 years ago

The page says that this is not open source, yet LICENSE.txt is MIT license. Please clear up on licensing.

SicLuceatLux commented 4 years ago

Does this mean one can request the sourcecode even with legal support ;) ?

shmerl commented 4 years ago

Why is it no longer open source? Is it temporary, or you don't plan to open it up anymore? I hope it's not because of some console NDAs.

himanshugoel2797 commented 4 years ago

Presumably MIT is meant to apply to the headers + samples?

yozhijk commented 4 years ago

Hi guys, Thanks for still being with us and for the feedback you have provided so far. It has been decided yesterday to open-source most of RadeonRays4 and put AMD specific IP in closed-source modules (source will be available upon request under SLA).

-Dmitry

SicLuceatLux commented 4 years ago

Thx @yozhijk great move !

lightistor commented 4 years ago

@yozhijk I presume you meant NDA as opposed to SLA.

qhaas commented 3 years ago

Question is, how long will legal limbo last: We're working on open sourcing what we can from the latest version with legal.

itmanager85 commented 3 years ago

Hi guys, It has been decided yesterday to open-source most of RadeonRays4 -Dmitry

So when will we see the source code of RadeonRays4 ? it's been almost a year since you promised to provide it ..

bsavery commented 3 years ago

So when will we see the source code of RadeonRays4 ? it's been almost a year since you promised to provide it ..

I would argue about 7.5 months being "almost a year" ;) However, that being said, please be patient. The people replying here are developers, not the legal dept. We'll post an update when we can!

Hi-Angel commented 3 years ago

So when will we see the source code of RadeonRays4 ? it's been almost a year since you promised to provide it ..

I would argue about 7.5 months being "almost a year" ;) However, that being said, please be patient. The people replying here are developers, not the legal dept. We'll post an update when we can!

Well, speaking of developers: if this project is even maintained, there's clearly something that could be done without waiting for legal team. Specifically, pull requests been piling up since 2018 year. Someone could review and accept them. That said, right now all PRs would clearly be in conflict because of the situation discussed. That could be worked around by first accepting https://github.com/GPUOpen-LibrariesAndSDKs/RadeonRays_SDK/pull/210 which reverts commits that brought those binaries, and then review and accept the rest of PRs.

Hi-Angel commented 3 years ago

Btw, there is something to be said about the AMD development team. I leave this comment specifically for AMD devs, because you folks will need to have an internal talk on your team.

Let's go back in time to July 2018. That was the time last commit was made to the repo. Then, some developer, let's call him Bob, decided to make another change to RadeonRays SDK. He finds some old private repo from before 2016 (in 2016 development moved to github), and makes a commit there. Why nobody noticed that? Do you even have a codereview? If he was explicitly asked to commit to the internal repo, why no one questioned that, didn't contact the legal team? And Bob wasn't the last dev who did that, there was a slew of others, and no one asked "why do we not use the Github repo, the development is been done there since 2016 year".

Please folks, bring this up on the next internal meeting, because this looks pretty frustrating, what a team…

gbeatty commented 3 years ago

It must be a shit show over there in AMD dev land. Product after product goes through this same cycle of release promising product to open source -> bugs & PR pile up which all get ignored -> product dies because there's no support. Why can't they get their act together?

ignaloidas commented 3 years ago

Closing since the source got published under an open source license.