Integration with latest ImGui (>1.89.3)

GPUOpen-LibrariesAndSDKs / RenderPipelineShaders

Render Pipeline Shaders SDK

MIT License

312 stars 24 forks source link

Integration with latest ImGui (>1.89.3) #21

Closed ChemistAion closed 1 year ago

ChemistAion commented 1 year ago

Since ImGui of 1.89.4 the intend of default math operators by #define IMGUI_DEFINE_MATH_OPERATORS must be expressed before including imgui.h. This was finally moved out from imgui_internal.h.

Otherwise triggers: https://github.com/ocornut/imgui/blob/6ca1556d029c9db8ccca30249f41fa1cca2a3445/imgui_internal.h#L98-L102

ChemistAion commented 1 year ago

ImGui 1.89.4 was just released (3h ago) and my PR does what's requested: https://github.com/GPUOpen-LibrariesAndSDKs/RenderPipelineShaders/pull/23

You could find the premises for this particular PR in the second bullet of "Breaking Changes" https://github.com/ocornut/imgui/releases/tag/v1.89.4

FlorianHerickAMD commented 1 year ago

This has been addressed in the latest update we just released. Thank you for reporting it!