GPUOpen-LibrariesAndSDKs / RenderPipelineShaders

Render Pipeline Shaders SDK
MIT License
312 stars 24 forks source link

Same filename stem for `rps_rpsl_host` leads to possible obj-output overwrite and it will slow compile/link cycle down #24

Closed ChemistAion closed 1 year ago

ChemistAion commented 1 year ago

In the rps_runtime lib-part we have two rps_rpsl_host sources expressed as a c and cpp with the same filename stem (in the same directory), respetivielly:

In the project CMake is used and it detects such a combo and generates full name-scope for these two files (no problem here):

...unfortunately in other build-systems THIS is, let's say not so obvious and ends up with obj-output overwritten :| My case datails: https://github.com/ubisoft/Sharpmake/issues/264

Could we please rename rps_rpsl_host.c to rps_rpsl_host_callbacks.c or something silimar? Premise: to better describe its purpose and help other than CMake build-systems to manage naming scheme.

ChemistAion commented 1 year ago

Please consider what is pointed out here: https://github.com/ubisoft/Sharpmake/issues/264

tl;dr: http://stackoverflow.com/a/1999344

FlorianHerickAMD commented 1 year ago

This has been addressed in the latest update we just released. Thank you for reporting it!