search

GPUOpen-LibrariesAndSDKs / RenderPipelineShaders

Render Pipeline Shaders SDK
MIT License
312 stars 24 forks source link

Build failure related to `external/` #3

Closed tksuoran closed 1 year ago

tksuoran commented 1 year ago

Build fails with build.bat after git clone https://github.com/GPUOpen-LibrariesAndSDKs/RenderPipelineShaders.git due to

CMake Error at external/CMakeLists.txt:35 (add_library):
  Cannot find source file:

    C:/git/tksuoran/RenderPipelineShaders/external/imgui/imgui.cpp

I did not immediately spot instructions how to deal with external. Personally I would use cmake fetch content so users would not need to do anything special.

Edit:

Info about my system: Windows 10, Git for Windows, Visual Studio 2022, build.bat called from command prompt with "%PROGRAMFILES%\Microsoft Visual Studio\2022\Professional\VC\Auxiliary\Build\vcvars64.bat" executed.

rys commented 1 year ago

imgui is a submodule dependency, so you need to make sure you've also cloned the submodules as well:

git submodule init and then git submodule update inside the RPS clone directory will update those and get the two submodules checked out in the right place, ready to build.

I'll add something to the README in the next update to make that clearer, thanks for the feedback!