Open ChemistAion opened 1 year ago
Which text-editors did you experience this with? For example, updates from Notepad++ seem to work just fine on my side.
@FlorianHerickAMD: Latest Notepad++ v8.4.9 x64 on Windows 10 Pro for Workstations (10.0.19045 Build 19045)
Additionally, I have conducted a second test on a different machine, and the results align with the previous findings. Please see the comment below.
@FlorianHerickAMD: I can also confirm this by testing with the latest Notepad++ v8.4.9 x64 on Windows 11 Enterprise (10.0.22621 Build 22621). RPS from fresh repo clone, builded with latest VS Community 2022 (17.6.2).
Scenario to reproduce:
tmp
cache-dir during these tryouts also makes no difference;d:\_rps
;Root cause: UM_FILE_CHANGED
message is not generated due to a missing SHCNRF_ShellLevel
flag in SHChangeNotifyRegister(...)
- as described in the first comment.
The issue persists in both Debug and Release configurations.
There is a missing
SHCNRF_ShellLevel
flag here - in the type of events for which to receive notifications: https://github.com/GPUOpen-LibrariesAndSDKs/RenderPipelineShaders/blob/31183408385c1e3e1711bd0320e17fcdf1ee07e9/tools/rpsl_explorer/src/file_monitor.hpp#L36-L41 It is necessary to include it to capture changes made, e.g. from text-editors (considered as aShellLevel
source).Other, minor things:
UM_FILE_CHANGED
should be type ofUINT
;ILCreateFromPathA
is not checked (in case of0
);m_registerIDs
- so it would be wrongly considered againPlease find my snipped with corrected version: