search

GPUOpen-LibrariesAndSDKs / VulkanMemoryAllocator

Easy to integrate Vulkan memory allocation library
MIT License
2.63k stars 359 forks source link

Not compiling when VMA_EXTERNAL_MEMORY_WIN32 disabled. #448

Open sagaceilo opened 2 months ago

sagaceilo commented 2 months ago

https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/blob/de8e65796ae5bf780a828c47376e6744bf1f4336/include/vk_mem_alloc.h#L10597

Hey,. this line is not compiling, when define switch is not specified. In one scenario VmaWin32Handle is a class with explicite handle construcor, but in other it has no public constructor at all.

Solution : remove VMA_NULL and leave only m_Handle() or remove line completly as it will fallback to default constructor in both cases.

Thanks :)

GamesTrap commented 2 months ago

Fixed by

Waiting for merge.