search

GPUOpen-LibrariesAndSDKs / display-library

AMD Display Library SDK
132 stars 46 forks source link

Function typedefs are not in public headers #17

Open bkaradzic opened 3 years ago

bkaradzic commented 3 years ago

Is there any good reason to not provide function signature typedefs inside public headers and have them scattered around examples?

https://github.com/GPUOpen-LibrariesAndSDKs/display-library/blob/209538e1dc7273f7459411a3a5044ffe2437ed95/Sample/Display/Display/Adl.h#L20-L31

https://github.com/GPUOpen-LibrariesAndSDKs/display-library/blob/209538e1dc7273f7459411a3a5044ffe2437ed95/Sample/Overdrive/Overdrive_Sample.cpp#L37-L70

It seem it would be better for usability to put all typedefs inside adl_sdk.h with ADL_MAIN_MALLOC_CALLBACK:

https://github.com/GPUOpen-LibrariesAndSDKs/display-library/blob/209538e1dc7273f7459411a3a5044ffe2437ed95/include/adl_sdk.h#L41