GPUOpen-Tools / GPU-Reshape

GPU Reshape (GRS) is an API agnostic instrumentation framework, with instruction level validation.
Other
359 stars 10 forks source link

Bump cmake minimum version to 3.24, required for CMP0135 policy support #51

Closed moarmand closed 5 months ago

moarmand commented 5 months ago

I had an issue while trying to generate visual studio solutions. It turns out my cmake version was too old and according to the documentation (https://cmake.org/cmake/help/latest/policy/CMP0135.html) CMP0135 has only been introduced in cmake 3.24.

miguel-petersen commented 5 months ago

Nice catch moarmand!

Could you please prepend the commit message with [Build], such that it would read "[Build] Bump cmake ...".

moarmand commented 5 months ago

Sure, that should be all good now.

miguel-petersen commented 5 months ago

Merged. Thanks!