Improving CMakeLists - Githubissues

GPUOpen-Tools / compressonator

Tool suite for Texture and 3D Model Compression, Optimization and Analysis using CPUs, GPUs and APUs

1.3k stars 196 forks source link

Improving CMakeLists #262

Closed bekorn closed 1 year ago

bekorn commented 1 year ago

Issue: https://github.com/GPUOpen-Tools/compressonator/issues/261

Major Changes

Makes cmake -DOPTIONBUILD*=ON/OFF arguments have an effect

Minor Changes

Improves the readability and utilization of CMake
[TODO] Update documentation This page https://compressonator.readthedocs.io/en/latest/build_from_source/build_instructions.html
[TODO] Pick default values for options

bekorn commented 1 year ago

Sorry that I didn't explain myself. I'm not familiar with the workflow of open source contribution. That is why I created a pull request "template", waiting for approval. As this had become a non-template, should I take it as approval? Is my solution doable?

Also, I don't think that I can pick the defaults by myself since I don't know the user base or common use case of the project. I will need your guidance on that.

denislevesqueAMD commented 1 year ago

@bekorn I will be taking a look at this and let you know if I spot anything that should be changed

denislevesqueAMD commented 1 year ago

@NPCompress This pull request should be closed. I made a new pull request, #267, that fixes the issue more thoroughly.

NPCompress commented 1 year ago

@bekorn Thank you for submission #262, with the help of @denislevesqueAMD a new pull request #267 with your changes and updates will be merged and this one will be closed. We encourage you and others to continue to request other pull request to better serve our community members. Thanks again for your contribution.