search

GPUOpen-Tools / compressonator

Tool suite for Texture and 3D Model Compression, Optimization and Analysis using CPUs, GPUs and APUs
1.28k stars 193 forks source link

BC7 UNORM SRGB support (KTX2) #277

Open 0x4E69676874466F78 opened 9 months ago

0x4E69676874466F78 commented 9 months ago

Why is only BC7 UNORM supported?

NavNTCMP commented 4 months ago

@w23 Merge code has build errors please review https://github.com/GPUOpen-Tools/compressonator/actions/runs/8249372923/job/22561614405 Issue is reopen for fix.

w23 commented 4 months ago

@w23 Merge code has build errors please review https://github.com/GPUOpen-Tools/compressonator/actions/runs/8249372923/job/22561614405 Issue is reopen for fix.

My apologies for breaking the build.

Would it be possible to set up GitHub actions to do pre-merge checks? It would help a lot with making and verifying PRs before they get merged.

I'll look into fixing the BC7 support when I get some free time.

SlawekNowy commented 4 months ago

Would it be possible to set up GitHub actions to do pre-merge checks? It would help a lot with making and verifying PRs before they get merged.

Putting trigger on pull request should be trivial...: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

From: https://github.com/marketplace/actions/pull-request-ticket-check-action

on:
  pull_request:
    types: ['opened', 'edited', 'reopened', 'synchronize']

Details: https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request

NavNTCMP commented 4 months ago

@SlawekNowy Thanks for the suggestion and links, The action script has been set to run on any pull request type for now. It may get limited, depending on build time usage.