search

GPUOpen-Tools / gpu_performance_api

GPU Performance API for AMD GPUs
MIT License
250 stars 46 forks source link

Clarification of Vulkan Example #35

Closed chaoticbob closed 5 years ago

chaoticbob commented 5 years ago

Can additional clarification be provided for: https://github.com/GPUOpen-Tools/GPA/blob/master/Src/Examples/Vulkan/VkColorCube/vkcolorcube.cpp#L1869-L1905

Based on the comments the first for loop only seems to apply when GPA is not loaded. If that's the case, shouldn't it belong in an else caluse? Additionally maybe the two IsLoaded() blocks could be merged since there's doesn't seem to be a logical reason why they're separated.

chesik-amd commented 5 years ago

The command buffers built in the first for loop are also used to continue rendering after all counters have been collected. See the else clause here: https://github.com/GPUOpen-Tools/GPA/blob/master/Src/Examples/Vulkan/VkColorCube/vkcolorcube.cpp#L1869-L1905

Yes, it does look like the two IsLoaded blocks can be merged. We'll take a look at doing this for the next GPA release.

Thanks for the feedback

chaoticbob commented 5 years ago

Thanks!