search

GPUOpen-Tools / gpu_performance_api

GPU Performance API for AMD GPUs
MIT License
250 stars 46 forks source link

Add support for building android-arm64 #64

Closed jcortell68 closed 2 years ago

jcortell68 commented 2 years ago

The Android support was limited to x64 in the build files. This adds arm64 support.

Note that build/pre_build.py argument --android has been replaced with two arguments: --androidx64 --androidarm64

jcortell68 commented 2 years ago

I'll take a look at what I overlooked in pre_build_common.py

Regarding argument format, yeah...I initially started coding it with an underscore then noticed no other arguments had one. So I decided to not rock the boat. But now that you're suggesting it, definitely...I'll rename the arguments, and also re-introduce the original unqualified one for backwards compatibility. Question, though...shall I make it a hidden option so as to steer people towards the qualified ones while still maintaining backwards compatibility for anyone that knows of the old option and is using it?

jcortell68 commented 2 years ago

I'll take a look at what I overlooked in pre_build_common.py

Oh gosh. It's not that I overlooked making changes to that file, it's that I forgot to include that file in the commit. Long story how that happened, but definitely a fumble on my part. Of course, I'll include it in the upcoming update.

jcortell68 commented 2 years ago

I submitted the new commit with the old --android argument in the help (i.e., not hidden). If you think hiding it is the better path, I'll tweak it.

jcortell68 commented 2 years ago

Ping