search

GPUOpen-Tools / gpu_performance_api

GPU Performance API for AMD GPUs
MIT License
250 stars 46 forks source link

The VkColorCube app doesn't log failure status #77

Open jcortell68 opened 1 year ago

jcortell68 commented 1 year ago

The failure status code being returned via the GPA calls aren't being logged by the VkColorCube app. It does log that what it's trying to do failed, but not why it failed (according to the GPA implementation). In my case a C++ exception was being thrown and that fact was just not surfaced at all.

Also changed the textual string for kGpaStatusErrorException to mention it's specifically a C++ exception, as otherwise the word "exception" is generic/vague and could be interepreted as such.

jcortell68 commented 1 year ago

I do agree that the actual error status code should be propagated up, but there are other changes here that should not be included.

Sorry Peter. I copied the files from my internal GPA repo to the external/github one and some unrelated, earlier internal changes bled in. I shold have checked the changed before doing the pull request. Cleaning up now...

jcortell68 commented 1 year ago

Mess fixed up. Again, sorry about that.