GPUOpen-Tools / ocat

The Open Capture and Analytics Tool (OCAT) provides an FPS overlay and performance measurement for D3D11, D3D12, and Vulkan
323 stars 29 forks source link

OCAT crashes HITMAN #40

Open brunogm0 opened 6 years ago

brunogm0 commented 6 years ago

HITMAN v 1.14.2.0

win10 pro

Crash when enabling Overlay.

aurolou commented 6 years ago

I pushed a fix, you can get the build here.

I noticed, that OCAT also hooks into the launcher, which can cause issues. To prevent these, you can do one of the following:

start the launcher -> (set your options as you like) -> enable the overlay -> start the game via the launcher or add Launcher.exe to the blackList.txt.

Hope this helps and the new build fixes your issue :)

brunogm0 commented 6 years ago

With OCAT open but no overlay active; the crash happens with message breakpoint. After this other attempts crashes with the old message but other address.

aurolou commented 6 years ago

Unfortunately, I can't reproduce the crash locally, the fix in version 1.2.0.168 solved the issue for me. So I need some further information from you to figure out the root cause of the problem :)

Do I understand correctly, that you just start OCAT, and without even enabling the overlay, HITMAN crashes on launch, but when OCAT is not running, HITMAN does launch without problems?

And how do you enable the overlay? Do you click on 'Start Overlay' in the Capture tab, or do you use the Advanced tab by starting HITMAN via the OCAT-UI? If you use the 'Start Overlay' in the Capture tab option, when do you turn it on: before you start the Launcher, or after you start the launcher but before you start the actual Hitman game? Do you run Hitman using DX11 or DX12?

Thanks :)

brunogm0 commented 6 years ago

Do I understand correctly, that you just start OCAT, and without even enabling the overlay, HITMAN crashes on launch, but when OCAT is not running, HITMAN does launch without problems?

Yes, but with launcher.exe in blacklist it changes to only crash after few seconds in the game.
ocat_hitman

Silent crashes with DX11 instead of DX12 (error as in the picture); OCAT click "Start Overlay on" silent crash launcher at options click; OCAT open but overlay off, allows to change options in launcher.exe;

Usually "click on 'Start Overlay' " but also tested advanced tab. In this case the error dialog is immediate. Also, tested advanced without "inject overlay at start", same instant crash dialog; If using advanced but selecting Launcher.exe, the error dialog changes to "bad conversion";

If overlay off then game start, hitman.exe is allocating memory steadly; (then overlay on) -> crash dialog happens only at first image print; aka, hitman.exe still loads when "overlay on" after start. I have the impression that after a few tries OCAT behaves differently maybe it stores something. GameOverlayLog.txt PresentMonLog.txt

Other tests: Never show overlay in: hitman, skullgirls or FFXV; Showed on Superposition, Quake Champions

ps.: RX460 18.8.1

aurolou commented 6 years ago

Thanks for the details! I could locally observe a thrown exception which I think is related to your issue, now I am looking for a way to solve it :)

aurolou commented 5 years ago

Hey, sorry for the delay. This version should work for FFXV, if you launch the game from OCAT (Launch App tab) and add as commandline argument: steam://run/637650

For Hitman, the global hook works for me, if not you can also try the explicit hook (launch the game directly from OCAT) with commandline argument: steam://run/236870

Make sure the steam client is running.

rys commented 5 years ago

Did that version fix your issue, @brunogm0?

brunogm0 commented 5 years ago

Sorry, my SSD failed and so i could not test it.