GPUOpen-Tools / radeon_compute_profiler

The Radeon Compute Profiler (RCP) is a performance analysis tool that gathers data from the API run-time and GPU for OpenCL™ and ROCm/HSA applications. This information can be used by developers to discover bottlenecks in the application and to find ways to optimize the application's performance.
MIT License
85 stars 19 forks source link

Incompatible git command #24

Open j-stephan opened 5 years ago

j-stephan commented 5 years ago

Hi,

when trying to follow the installation instructions for the master branch on Ubuntu 16.04 I encountered the following error:

$ python Scripts/UpdateCommon.py 
Cloning common-lib-amd-ADL into /home/jstephan/build/Common/Lib/AMD/ADL
error: unknown option `no-tags'
usage: git clone [<options>] [--] <repo> [<dir>]

    -v, --verbose         be more verbose
    -q, --quiet           be more quiet
    --progress            force progress reporting
    -n, --no-checkout     don't create a checkout
    --bare                create a bare repository
    --mirror              create a mirror repository (implies bare)
    -l, --local           to clone from a local repository
    --no-hardlinks        don't use local hardlinks, always copy
    -s, --shared          setup as shared repository
    --recursive           initialize submodules in the clone
    --recurse-submodules  initialize submodules in the clone
    --template <template-directory>
                          directory from which templates will be used
    --reference <repo>    reference repository
    --dissociate          use --reference only while cloning
    -o, --origin <name>   use <name> instead of 'origin' to track upstream
    -b, --branch <branch>
                          checkout <branch> instead of the remote's HEAD
    -u, --upload-pack <path>
                          path to git-upload-pack on the remote
    --depth <depth>       create a shallow clone of that depth
    --single-branch       clone only one branch, HEAD or --branch
    --separate-git-dir <gitdir>
                          separate git dir from working tree
    -c, --config <key=value>
                          set config inside the new repository

'git clone' failed with return code 129

Using python2 or python3 doesn't make a difference as this is a git error. I'm using the default git version in the Ubuntu repository:

$ git --version
git version 2.7.4

Removing the "no-tags" flag from the script worked for me but I don't know if this will cause issues at some point.

bjelich commented 5 years ago

Removing the "--no-tags" from the script will not cause any issues, but may increase the time it takes to clone projects. I don't recall what version of git introduced the "--no-tags" option, but it is available in git v2.11.