search

GPflow / GPflowOpt

Bayesian Optimization using GPflow
Apache License 2.0
270 stars 61 forks source link

Fixes the test_failsafe test on windows #56

Closed icouckuy closed 7 years ago

icouckuy commented 7 years ago

Should be a fairly simple fix for test_failsafe.

When opening an npz file it should be explicitly closed. On windows this causes problems when trying to remove the test npz file.

icouckuy commented 7 years ago

Note: all other tests succeeded on windows

codecov-io commented 7 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          14       14           
  Lines         757      757           
=======================================
  Hits          755      755           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8cc6fc...c0effb6. Read the comment docs.

javdrher commented 7 years ago

Thats better than I expected, cool!