error when using pygplates imported via gplately, but not via normal pygplates

GPlates / gplately

GPlately is a Python package to interrogate tectonic plate reconstructions.

https://gplates.github.io/gplately/

GNU General Public License v2.0

55 stars 12 forks source link

error when using pygplates imported via gplately, but not via normal pygplates #150

Closed nickywright closed 2 months ago

nickywright commented 7 months ago

I get an error when I try and use the gplately version of pygplates, but not the normally imported version of pygplates, when I try and use pygplates.Feature(). See screenshot with error.

michaelchin commented 2 months ago

Hi @brmather,

I am not sure about the comments below. Why is the Feature object associated with multiple files? Can you explain a bit this Feature class. I could not really understand the purpose of this class. https://github.com/GPlates/gplately/blob/14b41800431a90963e2ddef03400657d05fe540e/gplately/pygplates.py#L218-L220

And it seems that some of the comments were copied from pygplates doc. Maybe we should not duplicate the texts so that we don't have to change the comments each time pygplates changes its doc. Maybe a link to pygplates doc would be sufficient.

jcannon-gplates commented 2 months ago

On a side note: the next release of pyGPlates will have pickle support. I think the lack of support was one of the reasons for having a GPlately version of pygplates.Feature (and FeatureCollection, RotationModel). For example, to support parallel processing where a Feature can be reconstructed on another process using its (pickled) filename(s). So after the next pygplates release you might not need these classes - although I guess would still need them if the detected pygplates version is too old.